Verification improvements #1051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show re-send verification email only if the user has to verify email and route exists.
Fix StyleCI check
|
Hey @talelmishali. It seems you sent this in as a draft PR. Those aren't reviewed (See our contributor guide). I've sent in an alternative to this one: #1053 Thanks! |
I'll know for next time, I didn't want to send a PR that's is not fully ready to be merged. Anyway, thanks for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a new bug introduced after the recent improvement made on #1048. Upon new Jetstream installation where the user does not enable Fortify feature for email verification
Features::emailVerification(), the routeverification.sendis not registered and can create an error while trying to display the button for re-sending email verification link.On the Inertia stack we can see it here
jetstream/stubs/inertia/resources/js/Pages/Profile/Partials/UpdateProfileInformationForm.vue
Line 155 in 22a6923
jetstream/stubs/inertia/resources/js/Pages/Profile/Partials/UpdateProfileInformationForm.vue
Line 160 in 22a6923
As it tries to render
verification.sendroute, we will receive:Uncaught (in promise) Error: Ziggy error: route 'verification.send' is not in the route list.Currently, the PR fixes the bug only on the Inertia stack, I'll wait to hear from the Laravel team for what direction would like to go with it before spending more time on the Livewire stack fix.
Thanks again for all the hard work,
Tal