Fix gate check when updating user permissions on a team #1316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found a bug where managing a team member's role is being guarded by the
canAddTeamMembers
permissions instead ofcanUpdateTeamMembers
.This isn't super obvious right off the bat because they share the exact same logic, which is:
I spotted this in my own application when I changed the logic a bit so that both Administrators and Owners can invite new team members, but only Owners should be able to modify user permissions.