Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Pest detection #1353

Merged
merged 4 commits into from
Aug 8, 2023
Merged

[3.x] Pest detection #1353

merged 4 commits into from
Aug 8, 2023

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Aug 8, 2023

This PR updates the standalone Jetstream installer to default to Pest when it is already installed, either via the Laravel installer or installed manually.

When running php artisan jetstream:install with no arguments, the testing framework prompt will still be displayed, but defaulting to Pest when installed:

image

When passing arguments to the installer (e.g. php artisan jetstream:install inertia) the prompt does not appear. Currently, it will install PHPUnit tests unless the --pest flag was passed. With this change, it will automatically install Pest tests when appropriate.

See laravel/breeze#300

Copy link
Member

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessarcher I've improved the isUsingPest function.

@taylorotwell taylorotwell merged commit d356a6c into 3.x Aug 8, 2023
@taylorotwell taylorotwell deleted the pest-detection branch August 8, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants