-
Notifications
You must be signed in to change notification settings - Fork 845
[4.x] Migrates to Livewire v3.x
#1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After running
Ran |
On Team Settings page, when clicked on Save button on team name update, we see Saved message, but at the same time Added also appears in the Team Member section next to Add button. <x-action-message class="mr-3" on="saved">
{{ __('Saved.') }}
</x-action-message>
Maybe because both listening to same event?
|
On Possible reason is Alpine is not loaded now on this page. |
@awebartisan All fixed - and you can re-test if you want. |
stubs/livewire/resources/views/components/action-message.blade.php
Outdated
Show resolved
Hide resolved
stubs/livewire/resources/views/components/confirms-password.blade.php
Outdated
Show resolved
Hide resolved
I have tested the PR and everything works for me. |
Will this version be having legacy model binding? |
@andrewdwallo Where do you see legacy model binding being used? |
@nunomaduro I never said I did, but I'm not too familiar with the way Livewire 3 works yet, so I was just curious. I will take that as a no though. |
Hey! Thanks for the branch! I'm just migrating an existing project, but it seems that it does not detect the Jetstream components:
Any ideas? |
What version of Jetstream were you using? 2.x? If yes, you need to follow the upgrade guide to 3.x first. |
Ah, you're right, I was using 2.x! Thanks mate, it works now |
On action-message.blade.php component file, @this.on should be replaced by x-on since @this.on() deprecated in livewire 3 https://livewire.laravel.com/docs/upgrading#thison-deprecated , suggested fix #1365 |
@AbdullahObaid we've just added |
This pull request migrates Jetstream to Livewire
v3.x
. Wish to help with this pull request? Simply follow this instructions, and report any bugs you find: