Update two-factor-authentication-form.blade.php (Alternative centering the QRcode) #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to previous change, this change centers the QRcode so the extra white padding doesn't affect it's alignment relative to the text above and below in light or dark mode.
|
Here are some screenshots of this alternative. |
|
just a quick note, I tightened up the padding around the QR code from 4 to 2, it still works with the authenticator apps and looks a cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to previous change, this change centers the QRcode so the extra white padding doesn't affect it's alignment relative to the text above and below in light or dark mode.
If this looks like the preferred fix, I'll add one for inertia.