Skip to content

Modify two factor auth test #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Modify two factor auth test #793

wants to merge 2 commits into from

Conversation

ArielMejiaDev
Copy link
Contributor

Description

it adds a validation on TwoFactorAuthenticationSettingsTest on both stacks.

How it benefit end users

it would prevent a break on tests if two factor authentication feature is not enabled or is commented/removed in config/fortify.php:

'features' => [
        Features::registration(),
        Features::resetPasswords(),
        Features::emailVerification(),
        Features::updateProfileInformation(),
        Features::updatePasswords(),
//        Features::twoFactorAuthentication([
//            'confirmPassword' => true,
//        ]),
    ],

@driesvints
Copy link
Member

Remove the tests if you don't need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants