Skip to content

[1.x] Make PulseMigration compatible with Laravel v12.4: public shouldRun() #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2025

Conversation

onlime
Copy link
Contributor

@onlime onlime commented Mar 30, 2025

In Laravel v12.4.0 laravel/framework#55011, the following method was added to Illuminate\Database\Migrations\Migration:

    public function shouldRun(): bool
    {
        return true;
    }

so Laravel v12.4.0 breaks Pulse:

  In PulseMigration.php line 25:                                                                                                                                     
                                                                                                                                                                     
    Access level to Laravel\Pulse\Support\PulseMigration::shouldRun() must be public (as in class Illuminate\Database\Migrations\Migration)                              

This PR fixes it.

@tobya
Copy link

tobya commented Mar 30, 2025

I had this issue also.

I think your PR description should say that function shouldRun() was added rather than function getConnection()

@onlime
Copy link
Contributor Author

onlime commented Mar 30, 2025

I think your PR description should say that function shouldRun() was added rather than function getConnection()

oh, yes, thx. Fixed in the description.

@taylorotwell taylorotwell merged commit b3cf86e into laravel:1.x Mar 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants