Skip to content

Make shouldRun Public to avoid error. #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tobya
Copy link

@tobya tobya commented Mar 30, 2025

A recent change to Laravel Framework is causing an error when running migrations for Pulse.

Overview

A recent change in Laravel Framework introduced a public method shouldRun to the base Migration class.

This clashes somewhat with the method that the descendant class on pulse has except the method on the class in pulse is protected.

When I run my tests, phpunit complains

  Output:                                                                                                          
  ================                                                                                                 
                                                                                                                   
  In PulseMigration.php line 25:                                                                                   
                                                                                                                   
                                                                                                                   
    Access level to Laravel\Pulse\Support\PulseMigration::shouldRun() must be public (as in class Illuminate\Data  
  base\Migrations\Migration)

There are two solutions to this, one is to change the visability to public to match the ancestor visibility or change the name of the method in pulse. I have chosen to change the visibility but can change the name if desired.

A recent change to Laravel Framework is causing an error when running migrations for Pulse.
@tobya
Copy link
Author

tobya commented Mar 30, 2025

missed existing fix

@tobya tobya closed this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant