Make shouldRun Public to avoid error. #452
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to Laravel Framework is causing an error when running migrations for Pulse.
Overview
A recent change in Laravel Framework introduced a public method
shouldRun
to the base Migration class.This clashes somewhat with the method that the descendant class on pulse has except the method on the class in pulse is protected.
When I run my tests, phpunit complains
There are two solutions to this, one is to change the visability to public to match the ancestor visibility or change the name of the method in pulse. I have chosen to change the visibility but can change the name if desired.