-
Notifications
You must be signed in to change notification settings - Fork 169
Adding Two Factor Auth Feature #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tnylea
wants to merge
29
commits into
main
Choose a base branch
from
feature/2fa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+9,999
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkandarS0
reviewed
Apr 19, 2025
SkandarS0
reviewed
Apr 19, 2025
tnylea
commented
Apr 21, 2025
|
||
/* Allows us to transition an element from a certain length to its intrinsic size */ | ||
/* Learn more here: https://css-tricks.com/almanac/properties/i/interpolate-size/ */ | ||
interpolate-size: allow-keywords; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SkandarS0
reviewed
Apr 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to uninstall the radix-ui/react-tabs
package
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Two Factor Authentication to the React Starter Kit. This functions the same as the Livewire Starter Kit 2FA functionality, and all the
App\Actions\TwoFactor
are similar.The user can now click on the Two Factor Auth tab on the left in the settings page.
They can then click Enable
This will open the QR code modal. The user can scan the QR code/security code and click continue where will have to verify the code.
Next, they will have to verify the code from their Authenticator App
After entering the correct code the user will see that 2FA has been enabled as well as a list of all their recovery codes.
Next time the user tries to login to the application they will have to verify their 2FA code before they are authenticated.
Other Starter Kit 2FA Feature PR's
Vue: github.com/laravel/vue-starter-kit/pull/120
Livewire: github.com/laravel/livewire-starter-kit/pull/84