Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing semicolon to avoid unnecessary diff #32

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Add missing semicolon to avoid unnecessary diff #32

merged 1 commit into from
Oct 7, 2019

Conversation

roberto-aguilar
Copy link
Contributor

The default laravel's bootstrap.js file has a semicolon in the Echo import statement and even though the missing one in the scaffolded file is not strictly required, it causes an unnecessary diff if it is not there when the scaffolding happens.

image

The default laravel's bootstrap.js file has a semicolon in the Echo
import statement and even though the missing one in the scaffolded file
is not strictly required, it causes an unnecessary diff if it is not
there when the scaffolding happens.
@driesvints driesvints merged commit f8ea331 into laravel:master Oct 7, 2019
@driesvints
Copy link
Member

Thanks!

@roberto-aguilar roberto-aguilar deleted the missing-semicolon branch October 7, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants