Remove unnecessary SQLite file creation in test workflow #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2025
christophstockinger
added a commit
to christophstockinger/vue-starter-kit
that referenced
this pull request
Mar 5, 2025
christophstockinger
added a commit
to christophstockinger/vue-starter-kit
that referenced
this pull request
Mar 16, 2025
christophstockinger
added a commit
to christophstockinger/vue-starter-kit
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for providing amazing starter kits!
In the test workflow (tests.yml), SQLite file creation is included.
However, since
phpunit.xmlconfigures SQLite to run in memory during test execution, SQLite file is not needed in the test CI.vue-starter-kit/phpunit.xml
Lines 25 to 26 in 41b7b6a
I’ve also submitted same PRs for the React and Livewire starter kits:
React: laravel/react-starter-kit#52
Livewire: laravel/livewire-starter-kit#34