Macro support for cargo-free build systems #2922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlx is great and being able to use the macros under a non-cargo build system brings it to more people. Bazel, buck2, and soong are just some examples of these build systems. There are conceptually two places where cargo is run by sqlx: the prepare step and the build step. This patch addresses the build step by optionally replacing the workspace lookup with an envionment variable. For our case at least this is sufficient, as cargo can still be executed interactively, just not from with a build system action. I'm happy to structure this differently (e.g. make the workspace lookup lazy) - just let me know.
|
Closing in favor of #2927. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlx is great and being able to use the macros under a non-cargo build system brings it to more people. Bazel, buck2, and soong are just some examples of these build systems.
There are conceptually two places where cargo is run by sqlx: the prepare step and the build step.
This patch addresses the build step by optionally replacing the workspace lookup with an environment variable. For our case at least this is sufficient, as cargo can still be executed interactively, just not from with a build system action.
I'm happy to structure this differently (e.g. make the workspace lookup lazy) - just let me know.
Does your PR solve an issue?
Delete this text and add "fixes #(issue number)"