chore: experimental FDv2 configuration hooked up #853
Conversation
…ates, and FDv2 DataSource impls.
tanderson-ld
changed the title
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
| if (this._initPhaseActive && this._initFactories.pos() >= this._initFactories.length()) { | ||
| this._initPhaseActive = false; | ||
| this._syncFactories.reset(); | ||
| } |
There was a problem hiding this comment.
For reviewers: Bugfix found during testing with intermittent wifi. Error in last initializer was not leading to fallback to synchronizer. This is the fix and there are corresponding tests.
There was a problem hiding this comment.
For Reviewers: These changes have never been reviewed before, please review thoroughly.
There was a problem hiding this comment.
For reviewers: These changes have been reviewed before EXCEPT for "experimental" comment block.
There was a problem hiding this comment.
For reviewers: These changes have been reviewed before EXCEPT it has been modified to not adapt FDv1 configuration to the FDv2 data system.
| dsErrors.forEach((error) => { | ||
| this.logger?.warn(error); | ||
| }); | ||
| } |
There was a problem hiding this comment.
For reviewers: When this code was previously reviewed when merging to the FDv2 holding branch, there was an else block here that would map the FDv1 options to an FDv2 dataSystem. That has been removed to have FDv1 and FDv2 not have code overlap and improved separability.
Requirements
This PR adds new changes to LdClientImpl to utilize FDv2 as an experimental feature.
This PR also moves changes for FDv2 from the temporary holding branch to main.