Feature/connect improvements

[GuyLewin]

Solving #252 and #251

[GuyLewin]

@pintsized let me know if there are any adjustments necessary

[GuyLewin]

@pintsized what do you think?

[pintsized]

Looks good, although we'll need to update the README and add some tests. Are you able to include them in this PR? I can help with the tests if you're not familiar with it? I don't think we really have proper coverage for return values from connect to be honest, so would be great to have.

[GuyLewin]

@pintsized I tried adding UTs but I didn't have a good template to setup a local SSL server + use lua-resty-http as a client. If you can come up with a sample test for that - I can enhance and add more UTs.
I tried using www.google.com as the SSL server but that didn't work as well through GitHub Actions (the tests passed locally though). You can see all the logs in my branch - https://github.com/GuyLewin/lua-resty-http/actions/runs/1322151032
In any case - I updated the README. Hope we can proceed with the tests separately - but let me know if there's anything else for me to do!

[GuyLewin]

@pintsized once we merge this, I'll create a separate PR to fix #253 . I'm trying to avoid merge conflicts by doing one at a time. Do you think you'll have time to review this soon?

[pintsized]

@GuyLewin ok great, sounds good. And thank you! Yes, I promise I'll get to it soon, I'm just pretty busy atm. I'll see if I can get some SSL tests going on this though, so leave that to me.

[GuyLewin]

@pintsized sounds great, thanks! Let me know if there's any further changes needed in this repo. Otherwise I'll start working on the next one.

[GuyLewin]

@pintsized until this is approved, do you mind adding the hacktoberfest-accepted label to this PR and the other ones I opened?
It'll help me achieve the minimum threshold for Hacktoberfest :)
https://hacktoberfest.digitalocean.com/resources/participation

[pintsized]

@pintsized until this is approved, do you mind adding the hacktoberfest-accepted label to this PR and the other ones I opened?
It'll help me achieve the minimum threshold for Hacktoberfest :)

Sure thing! Sorry again, I am getting there, just snowed under. Thanks for the contributions!

[GuyLewin]

@pintsized until this is approved, do you mind adding the hacktoberfest-accepted label to this PR and the other ones I opened?
It'll help me achieve the minimum threshold for Hacktoberfest :)

Sure thing! Sorry again, I am getting there, just snowed under. Thanks for the contributions!

Thanks! No worries, we forked these branches into our codebase for now until we merge it into the upstream.

I'll also try closing and re-opening this PR in particular since I created it before Hacktoberfest.