Skip to content

refs #30 add support for X-Ray and full MethodSettings(incl. Cloudwatch Detailed Monitoring) #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mandyjohar23
Copy link

@mandyjohar23 mandyjohar23 commented Aug 30, 2019

Fixes #30

@mandyjohar23 mandyjohar23 changed the title refs #30 add support for X-Ray and full MethodSettings refs #30 add support for X-Ray and full MethodSettings(incl. Cloudwatch Detailed Monitoring) Sep 2, 2019
@roni-frantchi
Copy link

Thanks @mandyjohar23 .
Hey @leftclickben can we get this one in? Really need this one.

@sambP
Copy link

sambP commented Sep 20, 2020

@mandyjohar23 so currently, it is not possible to use something like this, right?

  stageSettings:
    MethodSettings:
      - ResourcePath: '/~1api~1auth'
        HttpMethod: '*'
        ThrottlingBurstLimit: 1
        ThrottlingRateLimit: 1

@sambP
Copy link

sambP commented Sep 20, 2020

Screenshot 2020-09-20 at 16 34 31

I tested my settings above with your pr, but it didn't seem to work.

@mandyjohar23
Copy link
Author

@sambP You can try to do sls package first(with plugin) and see if the local Cloudformation template has all the required properties that you want or not. If the CF template is correct then the deployment shouldn't have any problem.

@sambP
Copy link

sambP commented Sep 21, 2020

I searched in the cloudformation-template-create/udpate-stack.json file after a fresh "serverless package" for "thrott", but could not find anything.

My package.json
"serverless-api-stage": "leftclickben/serverless-api-stage#31/head",

plugins:
  - serverless-api-stage

This is strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for X-Ray and Full list of MethodSettings
3 participants