Various bug fixes and added contrived benchmarks. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrived benchmarks aim to test edge-cases that invoke specific algoritgms or worst-case possibilities for float parsing algorithms. These are specific strings for near-halfway cases, with varying number of digits, forcing use of the slowest algoritms. - Updated abseil version to fix bug with <limits> missing. - Change repository to the new home, `fastfloat/fast_float`. - Avoid printing `bug` repeatedly if the parsed time is 0, and print it only once per test.
|
Fantastic work! |
|
If you do run these benchmarks locally, I do recommend lowering the volume to 5,000-10,000, since some of these benchmarks run at |
|
Ok. I might tweak the benchmark later to make sure it is reasonable. |
|
Merging. I will adjust. Great stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrived benchmarks aim to test edge-cases that invoke specific
algoritgms or worst-case possibilities for float parsing algorithms.
These are specific strings for near-halfway cases, with varying number
of digits, forcing use of the slowest algoritms.
fastfloat/fast_float.bugrepeatedly if the parsed time is 0, and print it only once per test.These changes are useful to test the changes in fastfloat/fast_float#96. After benchmarking, the new benchmarks significantly outperform
strtodin GCC for near-halfway cases with many digits, which (from what I remember) uses gmplib internally, which definitely highlights the improved performance. It also outperforms every other implementation.