Skip to content

Commit fca6179

Browse files
DarkLight1337Gogs
authored and
Gogs
committed
Revert "[Feature] specify model in config.yaml (vllm-project#14855)" (vllm-project#15293)
Signed-off-by: DarkLight1337 <[email protected]>
1 parent be7f311 commit fca6179

File tree

4 files changed

+1
-22
lines changed

4 files changed

+1
-22
lines changed

docs/source/serving/openai_compatible_server.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ For example:
188188
```yaml
189189
# config.yaml
190190

191-
model: meta-llama/Llama-3.1-8B-Instruct
192191
host: "127.0.0.1"
193192
port: 6379
194193
uvicorn-log-level: "info"
@@ -197,13 +196,12 @@ uvicorn-log-level: "info"
197196
To use the above config file:
198197
199198
```bash
200-
vllm serve --config config.yaml
199+
vllm serve SOME_MODEL --config config.yaml
201200
```
202201

203202
:::{note}
204203
In case an argument is supplied simultaneously using command line and the config file, the value from the command line will take precedence.
205204
The order of priorities is `command line > config file values > defaults`.
206-
e.g. `vllm serve SOME_MODEL --config config.yaml`, SOME_MODEL takes precedence over `model` in config file.
207205
:::
208206

209207
## API Reference

tests/config/test_config_with_model.yaml

Lines changed: 0 additions & 7 deletions
This file was deleted.

tests/conftest.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,15 +1126,3 @@ def pytest_collection_modifyitems(config, items):
11261126
for item in items:
11271127
if "optional" in item.keywords:
11281128
item.add_marker(skip_optional)
1129-
1130-
1131-
@pytest.fixture(scope="session")
1132-
def cli_config_file():
1133-
"""Return the path to the CLI config file."""
1134-
return os.path.join(_TEST_DIR, "config", "test_config.yaml")
1135-
1136-
1137-
@pytest.fixture(scope="session")
1138-
def cli_config_file_with_model():
1139-
"""Return the path to the CLI config file with model."""
1140-
return os.path.join(_TEST_DIR, "config", "test_config_with_model.yaml")
File renamed without changes.

0 commit comments

Comments
 (0)