Skip to content

Revert "[Feature] specify model in config.yaml (#14855)" #15293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Revert "[Feature] specify model in config.yaml (#14855)" #15293

merged 1 commit into from
Mar 21, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Mar 21, 2025 •
edited by github-actions bot
Loading

This reverts commit 0fa3970.

@DarkLight1337 DarkLight1337 requested a review from hmellor March 21, 2025 15:29
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation frontend labels Mar 21, 2025
@vllm-bot vllm-bot merged commit baec0d4 into vllm-project:main Mar 21, 2025
8 of 10 checks passed
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@DarkLight1337 @erictang000
Revert "[Feature] specify model in config.yaml (vllm-project#14855)" (v…
0af5399 
…llm-project#15293)

Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 deleted the revert-14855 branch March 31, 2025 04:16
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 2, 2025
@DarkLight1337
Revert "[Feature] specify model in config.yaml (vllm-project#14855)" (v…
f31d8f7 
…llm-project#15293)

Signed-off-by: DarkLight1337 <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@DarkLight1337 @lulmer
Revert "[Feature] specify model in config.yaml (vllm-project#14855)" (v…
3ff593e 
…llm-project#15293)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
@DarkLight1337 @nishith-fujitsu
Revert "[Feature] specify model in config.yaml (vllm-project#14855)" (v…
23b90ca 
…llm-project#15293)

Signed-off-by: DarkLight1337 <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 29, 2025
@DarkLight1337
Revert "[Feature] specify model in config.yaml (vllm-project#14855)" (v…
fca6179 
…llm-project#15293)

Signed-off-by: DarkLight1337 <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@DarkLight1337 @shreyankg
Revert "[Feature] specify model in config.yaml (vllm-project#14855)" (v…
d1efd81 
…llm-project#15293)

Signed-off-by: DarkLight1337 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@DarkLight1337
Revert "[Feature] specify model in config.yaml (vllm-project#14855)" (v…
4ff1ba3 
…llm-project#15293)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmellor hmellor Awaiting requested review from hmellor hmellor is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @vllm-bot