Fix issue with PETSc that has METIS but no ParMETIS #2036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basic idea is that we don't want to mix building our own
METIS and using PETSc's ParMETIS. The different possibilities are:
| Parmetis in PETSc?
| yes | no
----------------------
yes | A | B
METIS in PETSc? ----------------------
no | C | D
A: PETSc was built with both METIS and ParMETIS support. In this case,
we use both from PETSc.
B: PETSc is built with METIS support but no ParMETIS support. In this
case, we use the METIS support and disable ParMETIS.
C: PETSc is built with no METIS support, but does have ParMETIS. I'm not
sure this is really possible, but in this case, we would build our
own METIS and disable ParMETIS support just to avoid mixing them.
D: PETSc is built with neither METIS nor ParMETIS support. In this case,
we build both on our own.
|
This should be cherry-picked onto the v1.4.0 branch (#2029). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously assumed the former implied the latter, but that is not always the case.