Fix 2006 bug with refinement within ES::reinit() #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was part of a half-baked attempt to support both "refine and coarsen prior to EquationSystems::reinit for CPU efficiency" and "refine and coarsen only within EquationSystems::reinit for memory efficiency" idioms, but the latter support was seriously broken.
|
👍 looks like a good candidate for backporting to v1.4.1 (#2029) as well. |
|
Agreed; clearly nobody is actually using this capability heavily but it would be nice to have it work, it fails in confusing ways when it doesn't work, and it's a really simple fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was part of a half-baked attempt to support both "refine and
coarsen prior to EquationSystems::reinit for CPU efficiency" and
"refine and coarsen only within EquationSystems::reinit for memory
efficiency" idioms, but the latter support was seriously broken.
The "optimization" being removed here didn't actually optimize any use cases, but did break some.
This is another unrelated bug caught by the unit tests I'm working on for #1938.