Mesh stitching fixes for NodeElems #2103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only set h_min in this way if it has not been previously updated. This ensures that h_min is the min over both meshes being stitched. Co-authored-by: John W. Peterson <[email protected]>
roystgnr
approved these changes
Apr 17, 2019
|
This can also be backported to 1.4.1 (#2029). |
jwpeterson
added a commit
to jwpeterson/libmesh
that referenced
this pull request
Apr 19, 2019
* Search only active elements as was done previously. * If the linear search ends in failure, fall back on using h_min==1 rather than repeating the linear search for every node in the node list.
jwpeterson
added a commit
that referenced
this pull request
Apr 19, 2019
* Search only active elements as was done previously. * If the linear search ends in failure, fall back on using h_min==1 rather than repeating the linear search for every node in the node list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code would previously compute an
h_minvalue of 0 in cases where the first elem in the mesh was aNodeElem, thereby causing all subsequent relative distance checks to fail.