Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PETSc version number for MatResetPreallocation #2170

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Fix PETSc version number for MatResetPreallocation #2170

merged 1 commit into from
Jul 2, 2019

Conversation

lindsayad
Copy link
Member

Refs #2169

@lindsayad lindsayad requested a review from fdkong July 2, 2019 21:02
@moosebuild
Copy link

Job Test on 2a03025 : invalidated by @lindsayad

@jwpeterson
Copy link
Member

Just going to merge because I don't think we have any libmesh PR tests for PETScs old enough to make a difference here.

@jwpeterson jwpeterson merged commit f3dd9fe into libMesh:master Jul 2, 2019
@lindsayad
Copy link
Member Author

Just going to merge because I don't think we have any libmesh PR tests for PETScs old enough to make a difference here.

Yea I guess you're right. We have one million different PETSc targets for MOOSE but apparently only one for libMesh.

@lindsayad lindsayad deleted the version-fix branch July 2, 2019 21:13
@jwpeterson
Copy link
Member

but apparently only one for libMesh.

I think we have two, "regular" and "PETSc master", unless there is a third one in the min-gcc/clang tests.

jwpeterson added a commit that referenced this pull request Oct 6, 2020
@jwpeterson
Combination of MoveInsertable fixes (#2170)
d25f5ad 
The master hashes of the commits cherry-picked and squashed to create this commit:

PR #2720
783091b

PR #2731
b67b3e4
0a1dbe4
73d58f2
3a61395
a6f14fe
00cd55d
1310eac

A similar "combined" commit should also be cherry-picked onto the
1.4.x and 1.5.x series and new patch-level releases should be made for
them, since this is an issue which prevents certain compilers from
being able to compile the library.

Refs #2710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdkong fdkong fdkong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lindsayad @moosebuild @jwpeterson @fdkong