Skip to content

Fix: testPeriodicLagrange2() unit test requires Exodus #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 5, 2020
Merged

Fix: testPeriodicLagrange2() unit test requires Exodus #2728

merged 4 commits into from
Oct 5, 2020

Conversation

jwpeterson
Copy link
Member

Refs #2717

@jwpeterson
Copy link
Member Author

jwpeterson commented Oct 5, 2020 •
edited
Loading

The first commit here should be cherry-picked onto 1.6.0-rc1, the rest were introduced more recently by #2681, and therefore aren't in 1.6.0.

@jwpeterson
Copy link
Member Author

Hmm... the last "fix" works around an issue where Nemesis can apparently still be enabled even when the user configures with --disable-exodus. I don't think this should be allowed since the Nemesis code reuses parts of the Exodus code... Instead I think the configure tests need to be updated so that --disable-exodus implies --disable-nemesis.

@jwpeterson jwpeterson merged commit ad19076 into libMesh:master Oct 5, 2020
@jwpeterson jwpeterson deleted the disable_exodus_fix branch October 5, 2020 03:19
@jwpeterson jwpeterson mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwpeterson