Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for overwriting nodesets #4121

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

Fix for overwriting nodesets #4121

wants to merge 2 commits into from

Conversation

DanielYankura
Copy link

  • When creating sidesets from nodesets if the sideset shares an id with a nodeset they are combined
  • This checks first that the two are actually the same (same id and same nodes)
  • If they are not the same the instead of overwriting a new id is assigned to the new nodeset
  • If this is to be merged some tests in MOOSE would have to be re-golded

refs idaholab/moose#30085

@DanielYankura DanielYankura marked this pull request as draft March 27, 2025 22:29
@DanielYankura
Fix for overwriting nodesets
a4bedf5 
- When creating sidesets from nodesets if the sideset shares an id with a nodeset they are combined
- This checks first that the two are actually the same (same id and same nodes)
- If they are not the same the instead of overwriting a new id is assigned to the new nodeset

refs idaholab/moose#30085
@DanielYankura
Now throws an error instead of attempting to renumber nodesets
98c714a 
- May need minor adjustments to work for when users manually rename sideset IDs
@DanielYankura DanielYankura force-pushed the overwriting_existing_nodeset branch from c18d9af to 98c714a Compare April 3, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanielYankura