This repository was archived by the owner on Nov 22, 2022. It is now read-only.
switch to using the standard libp2p upgrader #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this as a draft given our discussion of #17 . I don't see how the transport would work even in go libp2p, but I didn't do any testing of
go <-> golibp2p. It really doesn't work with js libp2p -> go libp2p using this as a transport.The problem lies in this transport trying to do its own muxing... so when the "standard" options on libp2p are set, it tries to do a security update and the multistream/1.0.0 protocol and that fails when talking to this transport.
This PR switches things around to use the default libp2p upgrader.
I realize this PR probably isn't mergable as is, but I figured I'd open it up for discussion.