empty Object returns as an error when integrating with js-ipfs

[ya7ya]

Hey @mkg20001 , Thanks for the cool module, I noticed the following when trying to use this with js-ipfs,

it returns an err when triggering listen , the err is just an empty object {} and I traced it back to the callback function on this.io.emit('ss-join', maStr, pubKeyStr, (err, sig) => {

if you simply ignore that empty object error if (err && Object.keys(err).length !== 0) , it works but i'm not sure thats a proper fix , and also sig returned undefined .

Thanks for your help, I appreciate the hard work 👍

[mkg20001]

This empty object might be the result of the server returning an error object and JSON.stringify turning it into an empty object.
I will look into the error later.
Btw are you running the latest version on master or npm?

[ya7ya]

I'm running the npm version, but I can try the latest one.

…

On Mon, Sep 18, 2017, 2:42 PM Maciej Krüger ***@***.***> wrote: This empty object might be the result of the server returning an error object and JSON.stringify turning it into an empty object. I will look into the error later. Btw are you running the latest version on master or npm? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA45Q9xWRLBVKCViMq3ZMc6sv9Vc6FLzks5sjmU3gaJpZM4PaR_9> .

[mkg20001]

I think the error could be caused by using ws-star-signal-1.servep2p.com as it's running an older version of ws-star and using ws-star-signal-3.servep2p.com instead should fix that.
Also are you creating the websocket-star transport with the id as argument (new WStar{ id: peerId }))?

[mkg20001]

@ya7ya I've solved the empty object bug. Now it should return a string or an error (in the latest git version)

[ya7ya]

@mkg20001 Thanks dude, I'll check it out. and yes I was using the peerId in the constructor as instructed 👍

[mkg20001]

Should have been fixed. Reopen if it regresses.