Skip to content

test: Investigate inconsistent webRTC Interop Tests #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maschad opened this issue Jun 21, 2023 · 5 comments · Fixed by libp2p/test-plans#310
Closed

test: Investigate inconsistent webRTC Interop Tests #1846

maschad opened this issue Jun 21, 2023 · 5 comments · Fixed by libp2p/test-plans#310
Assignees
Labels
kind/test Testing work P0 Critical: Tackled by core team ASAP

Comments

@maschad
Copy link
Member

maschad commented Jun 21, 2023

          WebRTC tests seem flaky to me. I don't think this is a resource issue in CI. Running these tests locally (in compose and npm test) also sometimes fail for me.

Let's remove the webrtc tests for now, and add them back in when they're not flaky.

Originally posted by @MarcoPolo in #1809 (comment)

@maschad maschad self-assigned this Jun 21, 2023
@maschad maschad moved this to 🛠️ Todo in js-libp2p Jun 21, 2023
@maschad maschad added kind/test Testing work P1 High: Likely tackled by core team if no one steps up labels Jun 21, 2023
@maschad maschad moved this from 🛠️ Todo to 🏃‍♀️In Progress in js-libp2p Jul 17, 2023
@maschad maschad moved this from 🏃‍♀️In Progress to 🛠️ Todo in js-libp2p Aug 7, 2023
@maschad maschad moved this from 🛠️ Todo to 🏃‍♀️In Progress in js-libp2p Aug 7, 2023
@p-shahi p-shahi added P0 Critical: Tackled by core team ASAP and removed P1 High: Likely tackled by core team if no one steps up labels Aug 7, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Aug 10, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Aug 10, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Aug 10, 2023
@danisharora099
Copy link

danisharora099 commented Aug 12, 2023

curious to know if there's an update on this or investigation around why these tests were flaky?
at @waku_org we have tests being flaky in a similar way where the peer:identify is not being triggered in the CI (mostly works locally, but also inconsistently doesn't trigger locally) and curious if these are related

@maschad

@maschad
Copy link
Member Author

maschad commented Oct 10, 2023

We should be able to re-enable these tests given the fixes merged in #2073

@maschad maschad moved this from 🛠️ Todo to 🏃‍♀️In Progress in js-libp2p Oct 10, 2023
@achingbrain
Copy link
Member

achingbrain commented Nov 6, 2023

at @waku_org we have tests being flaky in a similar way where the peer:identify is not being triggered in the CI

This should be fixed by #2206 - specifically the stream that runs identify was sometimes being missed due to a race condition so the peer:identify event would fail to fire.

@maschad
Copy link
Member Author

maschad commented Nov 6, 2023

We can verify once libp2p/test-plans#310 is merged to confirm we have consistent webRTC interoperability

@maschad
Copy link
Member Author

maschad commented Nov 15, 2023

Closed by libp2p/test-plans#310

@maschad maschad closed this as completed Nov 15, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️In Progress to 🎉Done in js-libp2p Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test Testing work P0 Critical: Tackled by core team ASAP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants