Skip to content

[circuit-relay] Callback was already called #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alanshaw opened this issue Nov 1, 2018 · 3 comments
Closed

[circuit-relay] Callback was already called #421

alanshaw opened this issue Nov 1, 2018 · 3 comments
Labels
kind/stale

Comments

@alanshaw
Copy link
Member

alanshaw commented Nov 1, 2018

To reproduce, start JS IPFS daemon with circuit relay enabled. Wait...(might be long), eventually:

$ jsipfs daemon
Initializing IPFS daemon...
Swarm listening on /p2p-circuit/ipfs/QmYsRYcrQAftGS5U6XRsHdxiVDdGowAfCCYZLgxgL5JGpu
Swarm listening on /p2p-circuit/ip4/0.0.0.0/tcp/4002/ipfs/QmYsRYcrQAftGS5U6XRsHdxiVDdGowAfCCYZLgxgL5JGpu
Swarm listening on /p2p-circuit/ip4/127.0.0.1/tcp/4003/ws/ipfs/QmYsRYcrQAftGS5U6XRsHdxiVDdGowAfCCYZLgxgL5JGpu
Swarm listening on /p2p-circuit/dns4/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star/ipfs/QmYsRYcrQAftGS5U6XRsHdxiVDdGowAfCCYZLgxgL5JGpu
Swarm listening on /ip4/127.0.0.1/tcp/4003/ws/ipfs/QmYsRYcrQAftGS5U6XRsHdxiVDdGowAfCCYZLgxgL5JGpu
Swarm listening on /ip4/127.0.0.1/tcp/4002/ipfs/QmYsRYcrQAftGS5U6XRsHdxiVDdGowAfCCYZLgxgL5JGpu
Swarm listening on /ip4/192.168.1.86/tcp/4002/ipfs/QmYsRYcrQAftGS5U6XRsHdxiVDdGowAfCCYZLgxgL5JGpu
Swarm listening on /dns4/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star/ipfs/QmYsRYcrQAftGS5U6XRsHdxiVDdGowAfCCYZLgxgL5JGpu
API listening on /ip4/127.0.0.1/tcp/5002
Gateway (read only) listening on /ip4/127.0.0.1/tcp/9090
Web UI available at http://127.0.0.1:5002/webui
Daemon is ready
/Users/alan/Code/protocol-labs/js-ipfs/node_modules/async/internal/onlyOnce.js:9
        if (fn === null) throw new Error("Callback was already called.");
                         ^

Error: Callback was already called.
    at /Users/alan/Code/protocol-labs/js-ipfs/node_modules/async/internal/onlyOnce.js:9:32
    at pull.collect (/Users/alan/Code/protocol-labs/js-ipfs/node_modules/libp2p-circuit/src/circuit/stream-handler.js:91:9)
    at /Users/alan/Code/protocol-labs/js-ipfs/node_modules/pull-stream/sinks/reduce.js:10:5
    at /Users/alan/Code/protocol-labs/js-ipfs/node_modules/pull-stream/sinks/drain.js:20:24
    at read (/Users/alan/Code/protocol-labs/js-ipfs/node_modules/pull-length-prefixed/src/encode.js:27:25)
    at /Users/alan/Code/protocol-labs/js-ipfs/node_modules/pull-stream/sources/values.js:19:7
    at /Users/alan/Code/protocol-labs/js-ipfs/node_modules/pull-length-prefixed/src/encode.js:25:5
    at next (/Users/alan/Code/protocol-labs/js-ipfs/node_modules/pull-stream/sinks/drain.js:16:11)
    at sink (/Users/alan/Code/protocol-labs/js-ipfs/node_modules/pull-stream/sinks/drain.js:37:9)
    at pull (/Users/alan/Code/protocol-labs/js-ipfs/node_modules/pull-stream/pull.js:41:14)
@jacobheun
Copy link
Contributor

@alanshaw is that using libp2p-circuit 0.2.x? This should be fixed in 0.3

@daviddias
Copy link
Member

Seems taht people will have a hardtime using circuit. Let's get that libp2p release out of the door.

@daviddias daviddias changed the title Callback was already called [circuit-relay] Callback was already called Aug 22, 2019
@daviddias daviddias transferred this issue from libp2p/js-libp2p-circuit Aug 22, 2019
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@dependabot @achingbrain
deps(dev): bump execa from 6.1.0 to 7.0.0 (libp2p#421)
04124d4 
Bumps [execa](https://github.com/sindresorhus/execa) from 6.1.0 to 7.0.0.
- [Release notes](https://github.com/sindresorhus/execa/releases)
- [Commits](sindresorhus/execa@v6.1.0...v7.0.0)

---
updated-dependencies:
- dependency-name: execa
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Potsides <[email protected]>
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@semantic-release-bot
chore(release): 7.0.3 [skip ci]
3ae2395 
## [7.0.3](libp2p/js-libp2p-kad-dht@v7.0.2...v7.0.3) (2023-03-10)

### Dependencies

* bump protons-runtime from 4.0.2 to 5.0.0 ([libp2p#416](libp2p/js-libp2p-kad-dht#416)) ([7ebf172](libp2p/js-libp2p-kad-dht@7ebf172))
* **dev:** bump execa from 6.1.0 to 7.0.0 ([libp2p#421](libp2p/js-libp2p-kad-dht#421)) ([04124d4](libp2p/js-libp2p-kad-dht@04124d4))
@wemeetagain
Copy link
Member

Circult relay implementation has completely changed since this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alanshaw @jacobheun @daviddias @wemeetagain @p-shahi