fix!: remove connection manager autodial option #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connection manager's `autoDial` option originally meant "dial every peer we discover". Then it changed to "if we have fewer than `minConnections`, dial peers from the peer store until we have more than `minConnections`". This is confusing and also redundant, since if we don't want to dial peers to ensure we have more than `minConnections` we can just set `minConnections` to `0`. Also fixes a bug where we actually configured two autodialer components.
maschad
reviewed
Mar 15, 2023
Co-authored-by: Chad Nehemiah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection manager's
autoDialoption originally meant "dial every peer we discover". Then it changed to "if we have fewer thanminConnections, dial peers from the peer store until we have more thanminConnections".This is confusing and also redundant, since if we don't want to dial peers to ensure we have more than
minConnectionswe can just setminConnectionsto0.Adds a section to the upgrade guide covering the removal.
Also fixes a bug where we actually configured two autodialer components.