fix: encapsulate /p2p-circuit multiaddrs when dialing a known peerid #1680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for creating a dial target is intended to ensure multiaddrs are encapsulated with `/p2p/${peerId}` IF the dial target's peer id is known. It uses `addr.getPeerId()` to check if this is already the case.
```
> multiaddr("/ip4/127.0.0.1/tcp/4001/p2p/12D3...").getPeerId()
'12D3...'
```
However, circuit relay addresses return the **relay server's** peer id if they don't end in `/p2p/${destinationPeerId}`.
```
> multiaddr("/ip4/127.0.0.1/tcp/4001/p2p/12D3.../p2p-circuit").getPeerId()
'12D3...'
```
Since the dialer then thinks the multiaddr already has a peer id, it doesn't encapsulate with `/p2p/${destinationPeerId}`, which ultimately results in failed dials to circuit relay destinations with error `ERR_RELAYED_DIAL` (`Circuit relay dial failed as addresses did not have peer id`). If I understand things right, the desired behavior is for circuit relay addresses to get encapsulated with the destination peer id.
|
Just want to bump this since I'm now confident this is breaking all dials to circuit-relay addresses, at least on our network. @achingbrain if you could take a look at this, I'd be really grateful 💜 |
achingbrain
approved these changes
Apr 14, 2023
|
Thanks! This fix is available via the There's a short upgrade guide to follow but it should be relatively painless unless you are doing a lot of custom stuff with the connection manager. $ npm i libp2p@next |
|
That works! Thank you so much! |
|
This has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for creating a dial target tries to ensure multiaddrs are encapsulated with
/p2p/${peerId}IF the dial target's peer id is known. It usesaddr.getPeerId() != nullto check if this is already the case.However, circuit relay addresses return the relay server's peer id if they don't end in
/p2p/${destinationPeerId}.Since the dialer then thinks the multiaddr already has a peer id, it doesn't encapsulate with
/p2p/${destinationPeerId}, which ultimately results in failed dials to circuit relay destinations (Circuit relay dial failed as addresses did not have peer id). If I understand things right, the desired behavior is for circuit relay addresses to get encapsulated with the destination peer id.