Skip to content

fix!: remove dialler language #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix!: remove dialler language #2085

merged 2 commits into from
Oct 9, 2023

Conversation

wemeetagain
Copy link
Member

Description

  • Remove the confusing "dialler" word in metrics, replacing with "dial_queue"

@wemeetagain wemeetagain requested a review from a team as a code owner September 27, 2023 15:51
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

II can agree to the metric name change but I left a comment re: the variable name changes

@wemeetagain wemeetagain merged commit 62a56b5 into master Oct 9, 2023
@wemeetagain wemeetagain deleted the fix/remove-dialler branch October 9, 2023 19:40
@achingbrain
Copy link
Member

Can you hold off merging breaking changes for the time being please, we’ll get these all in for v1

@github-actions github-actions bot mentioned this pull request Oct 9, 2023
@achingbrain achingbrain restored the fix/remove-dialler branch October 10, 2023 11:20
@achingbrain
Copy link
Member

I'm going to revert this so we can get the bug fix in #2139 out without needing a major release.

@achingbrain
Copy link
Member

Re-opened here: #2143

achingbrain pushed a commit that referenced this pull request Oct 25, 2023
* fix!: remove dialler language

* chore: address pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants