Skip to content

fix!: remove CodeError class #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 9, 2024
Merged

fix!: remove CodeError class #2688

merged 8 commits into from
Sep 9, 2024

Conversation

achingbrain
Copy link
Member

The CodeError class has been replaced with specific error subclasses with named constructors that use a .name property.

BREAKING CHANGE: instead of CodeError, use TimeoutError, UnexpectedPeerError, etc

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner September 9, 2024 09:13
@achingbrain
fix!: remove CodeError class
3693f04 
The `CodeError` class has been replaced with specific error
subclasses with named constructors that use a `.name` property.

BREAKING CHANGE: instead of `CodeError`, use `TimeoutError`, `UnexpectedPeerError`, etc
@achingbrain achingbrain merged commit 81ebe4e into main Sep 9, 2024
21 checks passed
@achingbrain achingbrain deleted the fix/remove-codeerror branch September 9, 2024 20:01
@tabcat tabcat mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain