-
Notifications
You must be signed in to change notification settings - Fork 480
test: Add Electron Transport Interop Ping Test #3036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test: Add Electron Transport Interop Ping Test #3036
Conversation
@achingbrain I have created the PR. Please review it. |
The newly added interop tests are failing - please can you run the tests locally and push a fix. Instructions of how to do this are in the readme. Also: build instructions for electron should be added to the readme same as for browsers/node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added test run is causing CI to fail, this cannot be merged until CI passes.
@sumanjeet0012 do you have time to finish this PR? |
I am busy with some core features of py-libp2p. |
Title
test: Add Electron Transport Interop Ping Test
Description
Closes #1942
This PR addresses the issue #1942 by adding interop ping tests for the Electron transport.
The changes made in the code are as follows :
Notes & open questions
If
secureChannels
andmuxers
in theelectron-version.json
file have incorrect values, please let me know where I can obtain the correct values.Change checklist