fix: close handshake datachannel after use #3076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some times the handshake datachannel can remain open which causes a memory leak and stops the process from exiting so explicitly close the channel after the noise handshake has completed. Also removes a redundant `raceSignal` - it's not necessary as we pass the signal in to the `connect` method.
|
Refs: ipshipyard/roadmaps#22 |
This was referenced Apr 15, 2025
Merged
achingbrain
added a commit
that referenced
this pull request
Apr 16, 2025
Removes the closing of the handshake datachannel after the connection has been opened because it breaks compatibility with rust-libp2p 53. This can be revisited after libp2p/rust-libp2p#5986 is resolved.
achingbrain
added a commit
that referenced
this pull request
Apr 16, 2025
Removes the closing of the handshake datachannel after the connection has been opened because it breaks compatibility with rust-libp2p 53. This can be revisited after libp2p/rust-libp2p#5986 is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some times the handshake datachannel can remain open which causes a memory leak and stops the process from exiting so explicitly close the channel after the noise handshake has completed.
Also removes a redundant
raceSignal- it's not necessary as we pass the signal in to theconnectmethod.Fixes #2625
Change checklist