Skip to content

chore: remove websocket star from package table #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2020

Conversation

vasco-santos
Copy link
Member

With the modules refactor, we do not support websocket-star anymore and it should be removed from the table

@jacobheun
Copy link
Contributor

related #544

@vasco-santos the package-list file needs to be updated as well. #544 includes an update to a lot of the tables. Can we make sure the table generation is working properly and update the json file?

@vasco-santos
Copy link
Member Author

Yeah, my bad! I always forget about the package-table 🤦‍♂

I fixed it now, but it created one issue: the script is gathering the leadMaintainer for libp2p-utp and libp2p-rendezvous, which supposedly are my responsibility. The thing is that they needed to be released so that the package.json published is updated. However, they are still missing implementation. Should we keep them for now as N/A or should we do that manually?

Regarding the build, that needs to be a PR to the package-table module. I can get a PR for it to fix the build links

@jacobheun
Copy link
Contributor

However, they are still missing implementation. Should we keep them for now as N/A or should we do that manually?

We should probably just remove them for the time being, until they are active modules.

Regarding the build, that needs to be a PR to the package-table module. I can get a PR for it to fix the build links

I already submitted a PR there and it should be in the latest package-table version.

just FYI, I am separately looking into the flakey CI test failures.

@vasco-santos vasco-santos force-pushed the chore/remove-websocket-star-from-package-table branch from 45f8fa8 to 5cec974 Compare March 4, 2020 09:38
@vasco-santos vasco-santos requested a review from jacobheun March 4, 2020 09:52
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobheun jacobheun merged commit 5a46419 into master Mar 4, 2020
@jacobheun jacobheun deleted the chore/remove-websocket-star-from-package-table branch March 4, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants