Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On every inbound message
GossipRouter
checks the peer score againstgraylistThreshold
to decide whether a message should be processed or ignored.The score calculation is not too cheap for extensive inbound message flow.
The following optimizations were made:
PeerHandler.getIP()
timeInMeshQuantum
. Ideally that should be made on something like RxObservableValue
s andBindings
to look nicer but that seems like an overkill for this changeacceptRequestsFrom
for peers with non-negative score to avoid score recalculation for every inbound message. The basic idea behind is thatgraylistThreshold
should be far below0
and if a peer has the score 0 or above we could unconditionally accept some reasonable amount of its messages for say 1 second.Performance
Profiling graph of
AbstractRouter.onInbound()
Before
After