Skip to content

Make identify::Config fields private #5660

Closed
@jxs

Description

@jxs

Description

they don't need to be public, we should make it consistent across the project and have them private with getters and setters

Motivation

see #5574 (comment) for more information on the why
NB: We should take advantage of the minor version #5574 introduces and land this with it

Current Implementation

Current implementation has identify::Config fields public

Are you planning to do it yourself in a pull request ?

Maybe

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions