-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ci(interop): Use run-interop-ping-test master latest hash #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With libp2p/test-plans#121 merged, we should be able to use @master directly. This includes libp2p/test-plans@6d1aed2, thus allowing interop tests to run from fork pull requests.
This reverts commit b4fb343.
I am assuming that the specific git commit hash was meant to be temporary, thus changing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK
The specific commit was to make sure the repos don't break if test-plans changes. I'd like to keep it. Does dependabot not send update PRs for this?
Dependabot has not send an update PR. I am assuming that this is due to the previous commit hash not being part of libp2p/test-plans I will reference a git commit hash instead of |
Retriggered @thomaseizinger pointing to a concrete git commit now, thus dismissing your review. Will merge to unblock other pull requests. Please still review when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Max!
Description
With libp2p/test-plans#121 merged, we should be able to use master directly. This commit references the latest test-plans commit hash.
This includes
libp2p/test-plans@6d1aed2, thus allowing interop tests to run from fork pull requests.
Notes
Links to any relevant issues
Open Questions
Change checklist
A changelog entry has been made in the appropriate crates