Skip to content

ci(interop): Use run-interop-ping-test master latest hash #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Feb 13, 2023

Description

With libp2p/test-plans#121 merged, we should be able to use master directly. This commit references the latest test-plans commit hash.

This includes
libp2p/test-plans@6d1aed2, thus allowing interop tests to run from fork pull requests.

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

With libp2p/test-plans#121 merged, we should be able to use @master
directly.

This includes
libp2p/test-plans@6d1aed2, thus
allowing interop tests to run from fork pull requests.
@mxinden
Copy link
Member Author

mxinden commented Feb 13, 2023

I am assuming that the specific git commit hash was meant to be temporary, thus changing to master here. @MarcoPolo and @thomaseizinger let me know if I understood this correctly.

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

The specific commit was to make sure the repos don't break if test-plans changes. I'd like to keep it. Does dependabot not send update PRs for this?

@mxinden
Copy link
Member Author

mxinden commented Feb 14, 2023

Dependabot has not send an update PR. I am assuming that this is due to the previous commit hash not being part of libp2p/test-plans master branch.

I will reference a git commit hash instead of master here instead.

@mxinden mxinden changed the title ci(interop): Use run-interop-ping-test master ci(interop): Use run-interop-ping-test master latest hash Feb 14, 2023
@mxinden
Copy link
Member Author

mxinden commented Feb 14, 2023

Retriggered libp2p-swarm test with flaky test (see #3465).

@thomaseizinger pointing to a concrete git commit now, thus dismissing your review. Will merge to unblock other pull requests. Please still review when you have time.

@mxinden mxinden dismissed thomaseizinger’s stale review February 14, 2023 17:32

now pointing to git commit

@mxinden mxinden merged commit 7c73bc3 into libp2p:master Feb 14, 2023
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants