-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(gossipsub): gracefully disable handler on stream errors #3625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 42 commits into
libp2p:master
from
vnermolaev:deprecate/gossipsub-close-event
Apr 14, 2023
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
1264345
Gossipsub: remove `ConnectionHandlerEvent::Close`
3c2fbce
Move error handling closer to the source.
b8fed53
Address PR comments.
f4cfbc3
Address PR comments.
e7e96ed
Address PR comments.
e37ba58
Use `void` instead of panic
thomaseizinger b6be9ce
Check created streams counter also for failed upgrades
thomaseizinger 1e06367
Merge branch 'libp2p:master' into deprecate/gossipsub-close-event
vnermolaev 415f648
Update changelog.
f87949d
Fix typo in changelog
thomaseizinger 9e12f9d
Remove outdated comments
thomaseizinger ee6cb02
Extract utility functions for classifying `ConnectionEvent`
thomaseizinger 3443a69
Set `outbound_substream_establishing` in a single place
thomaseizinger fef9751
Flatten match
thomaseizinger 7dec223
Avoid being stuck in "Poisoned" state for outbound streams
thomaseizinger 3163213
Don't handle error that is never constructed
thomaseizinger e28af53
Deprecate `HandlerError` entirely
thomaseizinger 0507493
Track # of outbound streams requested, not successfully established
mxinden b572895
Re-enqueue message when outbound stream fails
mxinden 12e9b53
Use early return instead of if-else
thomaseizinger fd4958d
Only send messages in `poll`
thomaseizinger 44dce05
Fix use of `DialUpgradeError` in `is_inbound` check
thomaseizinger 6a5f1d0
Merge branch 'master' into deprecate/gossipsub-close-event
thomaseizinger 3432ac0
Move changelog entry
thomaseizinger db59d23
Bump version
thomaseizinger b94ec28
Change log level to warn for bad events
thomaseizinger c5e3c41
Don't end log messages with periods
thomaseizinger c02a3a3
Use exhaustive match
thomaseizinger e94c2c7
Make error message consistently `debug` and use same wording
thomaseizinger a7ed378
Merge branch 'master' into deprecate/gossipsub-close-event
thomaseizinger 798ef5c
Update protocols/gossipsub/src/handler.rs
mxinden bbdf8f5
chore: bump libp2p-swarm to v0.42.2
mxinden af21589
Update Cargo.lock
mxinden f999f3e
Refactor keep alive mechanism
mxinden 397afa2
Do minor clean up
mxinden 9f44adc
Merge branch 'master' of https://github.com/libp2p/rust-libp2p into d…
mxinden b01e86f
Add debug for dropped message
mxinden 552cb08
Track MAX_SUBSTREAM_ATTEMPTS in on_connection_event
mxinden b42e71e
Update swarm/CHANGELOG.md
mxinden a958b60
Merge branch 'master' into deprecate/gossipsub-close-event
mxinden d673ed2
Merge branch 'master' into deprecate/gossipsub-close-event
mxinden 7cb4e41
Merge branch 'master' into deprecate/gossipsub-close-event
mxinden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.