-
Notifications
You must be signed in to change notification settings - Fork 288
add a spec for autonat #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
01501d4
3333735
048bdbf
bbd9a95
42ec1d0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,146 @@ | ||
# NAT Discovery | ||
> How we detect if we're behind a NAT. | ||
|
||
| Lifecycle Stage | Maturity | Status | Latest Revision | | ||
|-----------------|----------------|--------|-----------------| | ||
| 1A | Recommendation | Active | r0, 2021-08-26 | | ||
|
||
|
||
Authors: [@marten-seemann] | ||
|
||
Interest Group: [@mxinden], [@vyzo], [@raulk], [@stebalien], [@willscott] | ||
|
||
[@marten-seemann]: https://github.com/marten-seemann | ||
[@mxinden]: https://github.com/mxinden/ | ||
[@vyzo]: https://github.com/vyzo | ||
[@raulk]: https://github.com/raulk | ||
[@stebalien]: https://github.com/stebalien | ||
[@willscott]: https://github.com/willscott | ||
|
||
See the [lifecycle document][lifecycle-spec] for context about maturity level | ||
and spec status. | ||
|
||
[lifecycle-spec]: https://github.com/libp2p/specs/blob/master/00-framework-01-spec-lifecycle.md | ||
|
||
## Table of Contents | ||
|
||
- [Overview](#overview) | ||
- [AutoNAT Protocol](#autonat-protocol) | ||
- [RPC messages](#rpc-messages) | ||
- [Security Considerations](#security-considerations) | ||
|
||
## Overview | ||
|
||
A priori, a node cannot know if it is behind a NAT / firewall or if it is | ||
publicly reachable. Knowing its NAT status is essential for the node to be | ||
well-behaved in the network: A node that's behind a NAT doesn't need to | ||
advertise its (undiable) addresses to the rest of the network, preventing | ||
superfluous dials from other peers. Furthermore, it might actively seek to | ||
improve its connectivity by finding a relay server, which would allow other | ||
peers to establish a relayed connection. | ||
|
||
To determine if it is located behind a NAT, nodes use the `autonat` protocol. | ||
Using this protocol, the node requests other peers to dial its presumed public | ||
addresses. If a couple of these dial attempts succeed, the node can be reasonably | ||
certain that it is not located behind a NAT. Likewise, if a couple of these dial | ||
attempts fail, this is a strong indicator that a NAT is blocking incoming | ||
connections. | ||
|
||
## AutoNAT Protocol | ||
|
||
The AutoNAT Protocol uses the Protocol ID `/libp2p/autonat/1.0.0`. The node | ||
wishing to determine its NAT status opens a stream using this protocol ID, and | ||
then sends a `Dial` message. The `Dial` message contains a list of multiaddresses. | ||
Upon receiving this message, the peer starts to dial these addresses. It MAY | ||
dial all of them in parallel. The peer MAY use a different IP and peer ID than | ||
it uses for its regular libp2p connection to perform these dial backs. | ||
Comment on lines
+55
to
+56
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I understand correctly the fact that a server might use a different peer ID is due to an implementation detail in the Golang implementation. Given that AutoNAT is already widely deployed we won't be able to change that in this iteration. Still, would you mind documenting this, to ease discussions on this in future versions? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure we'd even want to change this in a future iteration, but I'm ok with documenting the reasoning here. Can you suggest some text? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I might be missing something here. What is the benefit of this amendment other than not having to fix the shortcomings within a single implementation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I disagree that this is a shortcoming to begin with. |
||
|
||
In order to prevent attacks like the one described in [RFC 3489, Section | ||
12.1.1](https://www.rfc-editor.org/rfc/rfc3489#section-12.1.1) (see excerpt | ||
below), implementations MUST NOT dial any multiaddress unless it is based on the | ||
IP address the requesting node is observed as. This restriction as well implies that | ||
implementations MUST NOT accept dial requests via relayed connections as one can | ||
not validate the IP address of the requesting node. | ||
|
||
> RFC 3489 12.1.1 Attack I: DDOS Against a Target | ||
> | ||
> In this case, the attacker provides a large number of clients with the same | ||
> faked MAPPED-ADDRESS that points to the intended target. This will trick all | ||
> the STUN clients into thinking that their addresses are equal to that of the | ||
> target. The clients then hand out that address in order to receive traffic on | ||
> it (for example, in SIP or H.323 messages). However, all of that traffic | ||
> becomes focused at the intended target. The attack can provide substantial | ||
> amplification, especially when used with clients that are using STUN to enable | ||
> multimedia applications. | ||
|
||
If all dials fail, the receiver sends a `DialResponse` message with the | ||
`ResponseStatus` `E_DIAL_ERROR`. If at least one of the dials complete | ||
successfully, it sends a `DialResponse` with the `ResponseStatus` `OK`. It | ||
SHOULD include the address it successfully dialed in its response. | ||
|
||
mxinden marked this conversation as resolved.
Show resolved
Hide resolved
|
||
The initiator uses the responses obtained from multiple peers to determine its | ||
NAT status. If more than 3 peers report a successfully dialed address, the node | ||
SHOULD assume that it is not located behind a NAT and publicly accessible. On | ||
the other hand, if more than 3 peers report unsuccessful dials, the node SHOULD | ||
assume that it is not publicly accessible. | ||
Nodes are encouraged to periodically re-check their status, especially after | ||
changing their set of addresses they're listening on. | ||
|
||
## RPC messages | ||
|
||
Messages are exchanged by: | ||
|
||
1. Opening a new stream. | ||
2. Sending the RPC request message. | ||
3. Listening for the RPC response message. | ||
|
||
All RPC messages sent over a stream are prefixed with the message length in | ||
bytes, encoded as an unsigned variable length integer as defined by the | ||
[multiformats unsigned-varint spec][uvarint-spec]. | ||
|
||
```proto | ||
syntax = "proto2"; | ||
|
||
message Message { | ||
enum MessageType { | ||
DIAL = 0; | ||
DIAL_RESPONSE = 1; | ||
} | ||
|
||
enum ResponseStatus { | ||
OK = 0; | ||
E_DIAL_ERROR = 100; | ||
E_DIAL_REFUSED = 101; | ||
E_BAD_REQUEST = 200; | ||
E_INTERNAL_ERROR = 300; | ||
} | ||
|
||
message PeerInfo { | ||
optional bytes id = 1; | ||
repeated bytes addrs = 2; | ||
} | ||
|
||
message Dial { | ||
optional PeerInfo peer = 1; | ||
} | ||
|
||
message DialResponse { | ||
optional ResponseStatus status = 1; | ||
optional string statusText = 2; | ||
optional bytes addr = 3; | ||
} | ||
|
||
optional MessageType type = 1; | ||
optional Dial dial = 2; | ||
optional DialResponse dialResponse = 3; | ||
} | ||
``` | ||
|
||
## Security Considerations | ||
|
||
Note that in the current iteration of this protocol, a node doesn't check if | ||
a peer's report of a successful dial is accurate. This might be solved in a | ||
future iteration of this protocol, see | ||
https://github.com/libp2p/go-libp2p-autonat/issues/10 for a detailed discussion. | ||
mxinden marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🙏 |
||
|
||
[uvarint-spec]: https://github.com/multiformats/unsigned-varint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
PeerInfo
that is send in theDial
message also (may?) contain the target's peer ID. Should it be enforced that this Peer ID matches the sender's Peer ID?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect addresses in
PeerInfo::addrs
not to contain peer IDs (/p2p/QmXXX
), given that the peer ID is already carried inPeerInfo::id
.That said, I would suggest to take the liberal approach of allowing addresses in
PeerInfo::addrs
to contain peer IDs anyways. Though in that case, I do agree that implementations should enforce the peer IDs to match.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I probably placed my comment wrong.
I was referring to
PeerInfo::id
, notPeerInfo::addrs
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, my bad.
The Golang implementation does the validation you suggest, namely validate that the peer ID in
PeerInfo
matches the remote's peer ID.https://github.com/libp2p/go-libp2p-autonat/blob/005802887af9a40607fad1283f0f16dbf31e93a9/svc.go#L90-L100
To be honest, I don't know why we send the peer ID in the first place. Maybe @marten-seemann knows more.