GPU: Validate shader bytecode #12707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmurray
force-pushed
the
gpu_validate_shaders
branch
from
3a38e99 to
dde4b21
Compare
madebr
reviewed
Apr 2, 2025
lmurray
force-pushed
the
gpu_validate_shaders
branch
from
dde4b21 to
7745f30
Compare
madebr
reviewed
Apr 2, 2025
lmurray
force-pushed
the
gpu_validate_shaders
branch
from
7745f30 to
48baf4b
Compare
lmurray
force-pushed
the
gpu_validate_shaders
branch
from
48baf4b to
0eee6ae
Compare
slouken
approved these changes
Apr 7, 2025
|
@thatcosmonaut, @TheSpydog, does this look good to you? |
thatcosmonaut
approved these changes
Apr 22, 2025
|
Looks good to me. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple users have attempted to pass uncompiled shader code into SDL_CreateGPUShader() and SDL_CreateGPUComputePipeline() and have gotten confused by the resulting error messages (e.g. #12522). This is a bigger deal for the D3D12 backend than the others as parsing the shader code is done lazily in that backend so the errors appear unrelated to shader compilation.
This PR adds a small sanity check to all backends that detects obviously-invalid shader code by checking for a magic number in the blob and returns a more helpful error message if hit. It is not possible to detect MSL via this method so the existing error handling is kept for that format.