Skip to content

Minimum libvips version set to 8.3 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marhub opened this issue Dec 6, 2016 · 4 comments
Closed

Minimum libvips version set to 8.3 #4

marhub opened this issue Dec 6, 2016 · 4 comments

Comments

@marhub
Copy link

marhub commented Dec 6, 2016

https://github.com/jcupitt/php-vips-ext/blob/master/config.m4#L7

This is on purpose ?
I have libvips 8.2 ( ubuntu 16.04, and currently can't update to 16.10 which has libvips in 8.3 ).

Changed that const to 8.2, recompiled, and it seems to be working.

jcupitt added a commit that referenced this issue Dec 6, 2016
8.2 added vips_bandjoin_const(), which php-vips needs

see #4
@jcupitt
Copy link
Member

jcupitt commented Dec 6, 2016

I agree, 8.2 seems to pass all tests. I tried 8.1, but that fails one.

I'll delay updating pecl again in case something else comes up in the next day or two, this seems like a relatively minor change.

Thanks!

@jcupitt
Copy link
Member

jcupitt commented Dec 6, 2016

I meant to say, I think the 8.3 was just because that was the current version when I started php-vips-ext, and I didn't want to explicitly support older libvipses.

@marhub
Copy link
Author

marhub commented Dec 6, 2016

Great!

@jcupitt
Copy link
Member

jcupitt commented Dec 30, 2016

OK, done! I'll close.

@jcupitt jcupitt closed this as completed Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants