Skip to content

Maintenance status of this repository? #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Jul 28, 2020 · 38 comments
Closed

Maintenance status of this repository? #225

ghost opened this issue Jul 28, 2020 · 38 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jul 28, 2020

It looks like the latest version, 3.9.2, was published in Jun, 2019. I'm wanting this fix made in Aug, 2019 so I can mock LoggerTakingImplicit in tests. When is the next release planned? I'm happy to help if I can. Thanks!

@SethTisue
Copy link
Collaborator

Doing #254 first, then this can go forward

@SethTisue
Copy link
Collaborator

SethTisue commented Feb 9, 2021

User-visible changes since 3.9.2:

The rest is just build changes and version bumps and such.

This release was brought to you by 13 contributors, according to git shortlog -sn --no-merges HEAD ^v3.9.2. Thank you Scala Steward, Seth Tisue, Philippus Baalman, sullis, Adriaan Moors, Francis De Brabandere, Eric Meisel, Dejan Stojadinović, Bruno Bonanno, Ty Coghlan, Kenji Yoshida, mwielocha, Krzysiek Bochenek.

@SethTisue
Copy link
Collaborator

SethTisue commented Feb 9, 2021

release job: https://travis-ci.com/github/lightbend/scala-logging/builds/216562258

and hmm, 2021-02-09 17:05:09.894Z error [Sonatype] [MISSING_PROFILE] Profile com.typesafe.scala-logging is not found. Check your sonatypeProfileName setting in build.sbt - (Sonatype.scala:405)

@SethTisue
Copy link
Collaborator

SethTisue commented Feb 9, 2021

I might be able to get the rights to publish to that org, but I think this is an opportune time to change Typesafe to Lightbend everywhere. I will also bump the version to 4.0.0.

@SethTisue
Copy link
Collaborator

SethTisue commented Feb 9, 2021

new release job: https://travis-ci.com/github/lightbend/scala-logging/builds/216566079

gah, 2021-02-09 17:36:20.845Z error [Sonatype] [MISSING_PROFILE] Profile com.lightbend is not found. Check your sonatypeProfileName setting in build.sbt - (Sonatype.scala:405)

I thought my Sonatype account had permissions to publish to com.lightbend, but I guess not. (I have them on Bintray, maybe got that confused in my head?)

Oh, it seems from https://issues.sonatype.org/browse/OSSRH-49971 that I have com.typesafe rights but not com.lightbend rights. But I guess the com.typesafe rights don't apply to com.typesafe.scalalogging? Regardless, I should get com.lightbend rights.

I think we should go forward with the renamings regardless.

I've made a query inside Lightbend about getting rights.

@SethTisue
Copy link
Collaborator

SethTisue commented Feb 9, 2021

I think we should go forward with the renamings regardless.

After discussing this with Adriaan, he convinced me we shouldn't do that, actually. And I have now reverted #259.

The issue is that there is a tendency for Lightbend customers -- and others! -- to assume that anything that says "lightbend" is supported by the company. Both in the sense of commercially supported and in other, more informal senses of "supported". (There is a notice about that in the readme now, but people make assumptions regardless.)

When people assume that, it has two downsides:

  1. Users may be upset or disappointed.
  2. New maintainers will be discouraged from stepping forward, if they think that Lightbend is already taking care of it.

But this library is now almost entirely community-maintained; no one from Lightbend is volunteering to play more than a minimal role here.

Ideally, there would be some sort of orphanage or halfway house that could be a home for libraries like this, where the original maintainers are no longer interested. I'm only vaguely aware of what exists in this space (https://adoptoposs.org?).

@SethTisue
Copy link
Collaborator

SethTisue commented Feb 9, 2021

@analytically Can I ask you how interested you are in this library?

Option 1: You could assume ownership entirely (under your personal account or under some other org), and cut all ties with Lightbend/Typesafe in the naming and publishing. We could transfer this repo to your ownership, or we could archive it and you could fire up an entirely new repo, which we'd link to.

Option 2a: We could leave the repo where it is, but you would assume responsibility for releases and publishing. Adriaan thinks you may already have the needed permissions on Sonatype; do you know if that's the case? Now that my sbt-ci-release PR is merged, all it takes to publish releases is for someone with the right Sonatype permissions to set the secure environment variables at https://travis-ci.com/github/lightbend/scala-logging/settings appropriately, following the instructions in the sbt-ci-release readme. And once they're set, publishing is as simple as using the GitHub web UI to create a tag+release.

Option 2b: We could leave the repo where it is, and I would acquire publishing permissions to com.typesafe.scalalogging and take over pulling release levers as needed.

Thoughts? I'm willing to do 2b if necessary, but my level of participation would remain quite minimal.
1 or 2a makes more sense if you're interested in actually seeing this library be healthy and not just straggle along on life support.

cc @adriaanm
cc @amumurst

@SethTisue SethTisue changed the title Publish new version to enable LoggerTakingImplicit mocking Maintenance status of this repository? Feb 9, 2021
@analytically
Copy link
Collaborator

I can publish a release. Easiest option.

@SethTisue
Copy link
Collaborator

SethTisue commented Feb 17, 2021

@analytically awesome! in that case we would prefer to leave everything under com.typesafe. this will minimize disruption for users, and it's also something of a signal (admittedly only a weak signal) that the library isn't being actively maintained by Lightbend.

have you used sbt-ci-release before? in order to do tag-based publishing, now that #254 is merged, you'll need to go to https://travis-ci.com/github/lightbend/scala-logging/settings and add PGP_PASSPHRASE, PGP_SECRET, SONATYPE_PASSWORD, and SONATYPE_USERNAME to the Environment Variables section, as per the instructions at https://github.com/olafurpg/sbt-ci-release/blob/master/readme.md . once that's set up, doing a release is as easy as pushing a tag (either from the command line, or via the GitHub web UI at https://github.com/lightbend/scala-logging/releases/new)

@analytically
Copy link
Collaborator

Ok I've setup the environment variables.

@SethTisue
Copy link
Collaborator

@analytically excellent! maybe it makes the most sense to land #227 first, then tag a release?

@analytically
Copy link
Collaborator

@SethTisue sounds good to me

@SethTisue
Copy link
Collaborator

#227 is merged.

@SethTisue
Copy link
Collaborator

@analytically ready to attempt a release?

@analytically
Copy link
Collaborator

@SethTisue yes

@SethTisue
Copy link
Collaborator

@analytically okay -- any questions for me about how to do it?

@analytically
Copy link
Collaborator

@SethTisue anything I need to do?

@SethTisue
Copy link
Collaborator

SethTisue commented Mar 16, 2021

@analytically yes, see my remarks above at #225 (comment) . if you push a tag (either via the GitHub web UI, or from the git command line, whichever you prefer; I like to use the GitHub web UI), sbt-ci-release should build and release it via Travis-CI

https://github.com/olafurpg/sbt-ci-release/blob/main/readme.md has full details

@analytically
Copy link
Collaborator

Strange, I can't seem to create a tag via the Web UI

@SethTisue
Copy link
Collaborator

SethTisue commented Mar 16, 2021

at https://github.com/lightbend/scala-logging/settings/access just now I upgraded you from "write" to "maintainer", maybe that will do it? I'm guessing

@SethTisue
Copy link
Collaborator

SethTisue commented Mar 16, 2021

at https://github.com/lightbend/scala-logging/releases there should be a "Draft a new release" button in the upper right

@analytically
Copy link
Collaborator

analytically commented Mar 16, 2021 via email

@SethTisue
Copy link
Collaborator

@SethTisue
Copy link
Collaborator

SethTisue commented Mar 16, 2021

2021-03-16 16:23:40.909Z error [Sonatype] [MISSING_PROFILE] Profile com.typesafe.scala-logging is not found. Check your sonatypeProfileName setting in build.sbt - (Sonatype.scala:408)

@SethTisue
Copy link
Collaborator

SethTisue commented Mar 16, 2021

Just an oversight in #258, I guess

@SethTisue
Copy link
Collaborator

@analytically sonatypeProfileName defaults to the value of organization, which is com.typesafe.scala-logging. Apparently that's not right?

I reviewed the diffs at #258 and I don't see anywhere where I removed something I shouldn't have.

@SethTisue
Copy link
Collaborator

Note that it's actually the same error message we got back in February: #225 (comment)

@tomasherman
Copy link

Hello, sorry to highjack this discussion but it's related to the original topic. It seems like this library is pretty much abandoned from the discussion ... does that mean there is not going to be a dotty (/scala3) release? Thanks

@SethTisue
Copy link
Collaborator

SethTisue commented Mar 19, 2021

@tomasherman good question. I've opened #269 about that specifically

EDIT: oh, haha, I forgot it was actually done already. so yes, once we get publishing straightened out, Scala 3 support will be published alongside Scala 2.

@SethTisue
Copy link
Collaborator

@analytically I have no idea what the problem is here 🤷

@analytically
Copy link
Collaborator

@SethTisue fixed it

@SethTisue
Copy link
Collaborator

Ah, I see #270 now.

You could push a v3.9.4 tag, or you could delete the existing v3.9.3 tag and then recreate it — either way should work for triggering publishing.

@analytically
Copy link
Collaborator

Pushed ...

@analytically
Copy link
Collaborator

2021-03-23 14:11:37.493Z info [SonatypeClient] repositoryReleased: id:comtypesafe-2822, target:releases - (SonatypeClient.scala:377)
2021-03-23 14:11:37.498Z info [SonatypeClient] [promote] Finished successfully - (SonatypeClient.scala:179)

@analytically
Copy link
Collaborator

Looks like it worked!

@SethTisue
Copy link
Collaborator

niiiiiice. as you probably know, the lag before the artifacts actually show up on Maven Central is unpredictable. monitoring https://repo1.maven.org/maven2/com/typesafe/scala-logging/scala-logging_2.13/3.9.3/

@SethTisue
Copy link
Collaborator

@SethTisue
Copy link
Collaborator

@analytically I added release notes to https://github.com/lightbend/scala-logging/releases/tag/v3.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants