Skip to content

Fix Android build openssl-sys error #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix Android build openssl-sys error #199

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18d1c1d
Fix openssl-sys error when building android bindings locally
alexanderwiederin Nov 17, 2023
d0beb8e
set `ANDROID_NDK_ROOT` and `LLVM_ARCH_PATH` depending on OS
alexanderwiederin Nov 19, 2023
59f6f21
Refactor for readability
alexanderwiederin Nov 20, 2023
5a1242a
Remove export flags for `CFLAGS` and `AR`
alexanderwiederin Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 58 additions & 5 deletions scripts/uniffi_bindgen_generate_kotlin_android.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,70 @@
#!/bin/bash

BINDINGS_DIR="bindings/kotlin"
TARGET_DIR="target"
PROJECT_DIR="ldk-node-android"
PACKAGE_DIR="org/lightningdevkit/ldknode"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused, let's remove it while we're here.

UNIFFI_BINDGEN_BIN="cargo run --manifest-path bindings/uniffi-bindgen/Cargo.toml"
ANDROID_NDK_ROOT="/opt/homebrew/share/android-ndk"
LLVM_ARCH_PATH="darwin-x86_64"

# The `export`s are required to make the variables available to subprocesses.
export CFLAGS="-D__ANDROID_MIN_SDK_VERSION__=21"
export AR=llvm-ar

OS=$(uname -s)

# TODO: Remove setting OPENSSL_DIR after BDK upgrade. Depends on: https://github.com/lightningdevkit/ldk-node/issues/195
# The OPENSSL_DIR configuration is currently necessary due to default features being enabled in our esplora-client.
# Check and set OPENSSL_DIR
if [ -z "$OPENSSL_DIR" ]; then
case "$OS" in
Darwin)
# macOS
export OPENSSL_DIR="/opt/homebrew/Cellar/openssl@3/3.1.4"
;;
Linux)
# Linux
export OPENSSL_DIR="/usr/local/openssl"
;;
*)
esac
fi

# Check and set ANDROID_NDK_ROOT
if [ -z "$ANDROID_NDK_ROOT" ]; then
case "$OS" in
Darwin)
# macOS
export ANDROID_NDK_ROOT="/opt/homebrew/share/android-ndk"
;;
Linux)
# Linux
export ANDROID_NDK_ROOT="/opt/android-ndk"
;;
*)
esac
fi

# Check and set LLVM_ARCH_PATH
if [ -z "$LLVM_ARCH_PATH" ]; then
case "$OS" in
Darwin)
# macOS
export LLVM_ARCH_PATH="darwin-x86_64"
;;
Linux)
# Linux
export LLVM_ARCH_PATH="linux-x86_64"
;;
*)
esac
fi

PATH="$ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/$LLVM_ARCH_PATH/bin:$PATH"

rustup target add x86_64-linux-android aarch64-linux-android armv7-linux-androideabi
CFLAGS="-D__ANDROID_MIN_SDK_VERSION__=21" AR=llvm-ar CARGO_TARGET_X86_64_LINUX_ANDROID_LINKER="x86_64-linux-android21-clang" CC="x86_64-linux-android21-clang" cargo build --profile release-smaller --features uniffi --target x86_64-linux-android || exit 1
CFLAGS="-D__ANDROID_MIN_SDK_VERSION__=21" AR=llvm-ar CARGO_TARGET_ARMV7_LINUX_ANDROIDEABI_LINKER="armv7a-linux-androideabi21-clang" CC="armv7a-linux-androideabi21-clang" cargo build --profile release-smaller --features uniffi --target armv7-linux-androideabi || exit 1
CFLAGS="-D__ANDROID_MIN_SDK_VERSION__=21" AR=llvm-ar CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER="aarch64-linux-android21-clang" CC="aarch64-linux-android21-clang" cargo build --profile release-smaller --features uniffi --target aarch64-linux-android || exit 1
CARGO_TARGET_X86_64_LINUX_ANDROID_LINKER="x86_64-linux-android21-clang" CC="x86_64-linux-android21-clang" cargo build --profile release-smaller --features uniffi --target x86_64-linux-android || exit 1
CARGO_TARGET_ARMV7_LINUX_ANDROIDEABI_LINKER="armv7a-linux-androideabi21-clang" CC="armv7a-linux-androideabi21-clang" cargo build --profile release-smaller --features uniffi --target armv7-linux-androideabi || exit 1
CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER="aarch64-linux-android21-clang" CC="aarch64-linux-android21-clang" cargo build --profile release-smaller --features uniffi --target aarch64-linux-android || exit 1
$UNIFFI_BINDGEN_BIN generate bindings/ldk_node.udl --language kotlin -o "$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/kotlin || exit 1

JNI_LIB_DIR="$BINDINGS_DIR"/"$PROJECT_DIR"/lib/src/main/jniLibs/
Expand Down