Skip to content

make channel reserve configurable #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
moneyball opened this issue May 26, 2022 · 0 comments · Fixed by #1619
Closed

make channel reserve configurable #1498

moneyball opened this issue May 26, 2022 · 0 comments · Fixed by #1619
Assignees
@G8XSU
Labels
good first issue Good for newcomers

Comments

@moneyball
Copy link
Contributor

Do we allow 0-1%? I think so because we accept 0 channel reserve for counterparty, which implies we expect and support such a use case (with associated security tradeoffs).
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label May 26, 2022
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 15, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_satoshis' while …
4685486 
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
@G8XSU G8XSU mentioned this issue Jul 15, 2022
Merged
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 16, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_satoshis' while …
ca48586 
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 16, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_satoshis' while …
074d9e2 
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 16, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_satoshis' while …
a6674c7 
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 18, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_satoshis' while …
991bf5f 
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 18, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_satoshis' while …
23ab0b9 
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 19, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_proportion_milli…
e2671c7 
…onth' while channel open/accept [lightningdevkit#1498]

`their_channel_reserve_proportion_millionth` is proportion of the channel_value to configure
counterparty's channel_reserve i.e `their_channel_reserve_satoshis` for both outbound and
inbound channels.
`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a
direct payment. This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 20, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_proportion_milli…
6c5d0ba 
…onth' [lightningdevkit#1498]

It is proportion of the channel value to configure as the `their_channel_reserve_satoshis`
for both outbound and inbound channels.
`their_channel_reserve_satoshis` is the minimum balance that the other node has to maintain
 on their side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 20, 2022
@G8XSU
Add configuration support for 'their_channel_reserve_proportion_milli…
457b135 
…onth' [lightningdevkit#1498][lightningdevkit#1606]

It is proportion of the channel value to configure as the `their_channel_reserve_satoshis`
for both outbound and inbound channels.
`their_channel_reserve_satoshis` is the minimum balance that the other node has to maintain
 on their side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 20, 2022
@G8XSU
Add config support for 'their_channel_reserve_proportion_millionth' [l…
a96edaf 
…ightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 29, 2022
@G8XSU
Add config support for 'their_channel_reserve_proportion_millionth' [l…
0fd574c 
…ightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 29, 2022
@G8XSU
Add config support for 'their_channel_reserve_proportion_millionth' [l…
eb62099 
…ightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Aug 1, 2022
@G8XSU
Add config support for 'their_channel_reserve_proportion_millionths' [l…
7c90ee3 
…ightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Aug 1, 2022
@G8XSU
Add config support for 'their_channel_reserve_proportional_millionths' [
93ccd7f 
lightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Aug 2, 2022
@G8XSU
Add config support for 'their_channel_reserve_proportional_millionths' [
f509398 
lightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Aug 2, 2022
@G8XSU
Add config support for 'their_channel_reserve_proportional_millionths' [
092d1c1 
lightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
TheBlueMatt added a commit that referenced this issue Aug 3, 2022
@TheBlueMatt
Merge pull request #1619 from G8XSU/main
736c0b9 
Add config support for 'their_channel_reserve_proportional_millionths' [#1498]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G8XSU G8XSU

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add config support for 'their_channel_reserve_proportional_millionths' [#1498] G8XSU/rust-lightning
3 participants
@moneyball @TheBlueMatt @G8XSU