Skip to content

make channel reserve configurable #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moneyball opened this issue May 26, 2022 · 0 comments · Fixed by #1619
Closed

make channel reserve configurable #1498

moneyball opened this issue May 26, 2022 · 0 comments · Fixed by #1619
Assignees
Labels
good first issue Good for newcomers

Comments

@moneyball
Copy link
Contributor

Do we allow 0-1%? I think so because we accept 0 channel reserve for counterparty, which implies we expect and support such a use case (with associated security tradeoffs).

@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label May 26, 2022
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 15, 2022
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 16, 2022
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 16, 2022
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 16, 2022
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 18, 2022
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 18, 2022
…channel open/accept [lightningdevkit#1498]

`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a direct payment.
This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 19, 2022
…onth' while channel open/accept [lightningdevkit#1498]

`their_channel_reserve_proportion_millionth` is proportion of the channel_value to configure
counterparty's channel_reserve i.e `their_channel_reserve_satoshis` for both outbound and
inbound channels.
`their_channel_reserve_satoshis` is the minimum amount that the other node is to keep as a
direct payment. This ensures that if our counterparty broadcasts a revoked state, we can punish them by
claiming at least this value on chain.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 20, 2022
…onth' [lightningdevkit#1498]

It is proportion of the channel value to configure as the `their_channel_reserve_satoshis`
for both outbound and inbound channels.
`their_channel_reserve_satoshis` is the minimum balance that the other node has to maintain
 on their side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 20, 2022
…onth' [lightningdevkit#1498][lightningdevkit#1606]

It is proportion of the channel value to configure as the `their_channel_reserve_satoshis`
for both outbound and inbound channels.
`their_channel_reserve_satoshis` is the minimum balance that the other node has to maintain
 on their side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 20, 2022
…ightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 29, 2022
…ightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Jul 29, 2022
…ightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Aug 1, 2022
…ightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Aug 1, 2022
lightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Aug 2, 2022
lightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
G8XSU added a commit to G8XSU/rust-lightning that referenced this issue Aug 2, 2022
lightningdevkit#1498]

It is proportion of the channel value to configure as the
`their_channel_reserve_satoshis` for both outbound and inbound channels.
It decides the minimum balance that the other node has to maintain on their
side, at all times.
TheBlueMatt added a commit that referenced this issue Aug 3, 2022
Add config support for 'their_channel_reserve_proportional_millionths' [#1498]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants