Move CounterpartyForwardingInfo from channel to channelmanager #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 65 65
Lines 33281 33281
=======================================
Hits 30232 30232
Misses 3049 3049
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
Sep 7, 2021
CounterpartyForwardingInfo is public (previously exposed with a `pub use`), and used inside of ChannelCounterparty in channelmanager.rs. However, it is defined in channel.rs, away from where it is used. This would be fine, except that the bindings generator is somewhat confused by this - it doesn't currently support interpreting `pub use` as a struct to expose, instead ignoring it. Fixes lightningdevkit/ldk-garbagecollected#44
TheBlueMatt
force-pushed
the
2021-09-fix-bindings-ignore
branch
from
c4162ca to
3f9efe7
Compare
|
Rebased. |
jkczyz
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CounterpartyForwardingInfo is public (previously exposed with a
pub use), and used inside of ChannelCounterparty inchannelmanager.rs. However, it is defined in channel.rs, away from
where it is used.
This would be fine, except that the bindings generator is somewhat
confused by this - it doesn't currently support interpreting
pub useas a struct to expose, instead ignoring it.Fixes lightningdevkit/ldk-garbagecollected#44