Add node id to custom message callback #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
- Coverage 90.83% 90.83% -0.01%
==========================================
Files 65 65
Lines 33281 33281
==========================================
- Hits 30232 30231 -1
- Misses 3049 3050 +1
Continue to review full report at Codecov.
|
TheBlueMatt
approved these changes
Sep 14, 2021
lightning/src/ln/peer_handler.rs
Outdated
| @@ -47,7 +47,7 @@ use bitcoin::hashes::{HashEngine, Hash}; | |||
| pub trait CustomMessageHandler: wire::CustomMessageReader { | |||
| /// Called with the message type that was received and the buffer to be read. | |||
| /// Can return a `MessageHandlingError` if the message could not be handled. | |||
| fn handle_custom_message(&self, msg: Self::CustomMessage) -> Result<(), LightningError>; | |||
| fn handle_custom_message(&self, msg: Self::CustomMessage, org: &PublicKey) -> Result<(), LightningError>; | |||
There was a problem hiding this comment.
Can you rename org to something more descriptive like "sender_node_id"?
There was a problem hiding this comment.
Better indeed updated
Tibo-lg
force-pushed
the
add-node-id-to-custom-msg-cb
branch
from
3c44988 to
2c6a078
Compare
TheBlueMatt
approved these changes
Sep 15, 2021
valentinewallace
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to integrate the rust-lightning custom message handler with my code I realized that I was missing the ability to access the node id of the originating node... (sorry for that but hopefully I'm probably the only one using this feature for now)