-
Notifications
You must be signed in to change notification settings - Fork 406
Consider many first-hop paths to the same counterparty in routing #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider many first-hop paths to the same counterparty in routing #1100
Conversation
Previously we'd simply overwritten "the" first hop path to each counterparty when routing, however this results in us ignoring all channels except the last one in the `ChannelDetails` list per counterparty.
Note that this was a user-reported bug, so tagging it 0.0.102 to keep the "user reported bugs get fixed w/i one release" deadline. |
Codecov Report
@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 90.64% 90.58% -0.06%
==========================================
Files 65 65
Lines 34226 34549 +323
==========================================
+ Hits 31024 31297 +273
- Misses 3202 3252 +50
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One q but seems legit and test fails as expected on main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fan-tastic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only change I'd wish for is a more descriptive macro name than add_entry
.
I'll let someone else tackle that in a followup - |
Previously we'd simply overwritten "the" first hop path to each
counterparty when routing, however this results in us ignoring all
channels except the last one in the
ChannelDetails
list percounterparty.