Move events.rs into its own top-level module #2083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
reviewed
Mar 10, 2023
|
CI is sad because |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2083 +/- ##
==========================================
- Coverage 91.43% 91.40% -0.03%
==========================================
Files 101 102 +1
Lines 49536 49536
Branches 49536 49536
==========================================
- Hits 45291 45278 -13
- Misses 4245 4258 +13
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This is largely motivated by some follow-up work for anchors that will introduce an event handler for `BumpTransaction` events, which we can now include in this new top-level `events` module.
Its accompanying event handler will also live here.
|
Had to rebase due to a conflict. |
TheBlueMatt
approved these changes
Mar 24, 2023
tnull
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely motivated by some follow-up work for anchors that will introduce an event handler for
BumpTransactionevents, which we can now include in this new top-leveleventsmodule.