Verify channel-monitor processes blocks with skipped best_block #2566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G8XSU
force-pushed
the
check-best-block-2538
branch
from
eb0847e to
a349b53
Compare
This can happen due to races b/w client's call to block_connect and adding newly created channel-monitor to chain-monitor using watch_channel in funding_created.
G8XSU
force-pushed
the
check-best-block-2538
branch
from
a349b53 to
d926be2
Compare
That was one of the solutions proposed but we discussed it, we shouldn't be needing that for now. Concern was for race-condition and we would have done that if there was a problem in correctness. |
wpaulino
approved these changes
Sep 11, 2023
TheBlueMatt
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen due to races b/w client's call to block_connect
and adding newly created channel-monitor to chain-monitor using
watch_channel in funding_created.
Detailed description in tests.
Closes #2538